Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Implement the Webex notifier #58480

Merged
merged 11 commits into from Nov 11, 2022
Merged

Alerting: Implement the Webex notifier #58480

merged 11 commits into from Nov 11, 2022

Conversation

gotjosh
Copy link
Contributor

@gotjosh gotjosh commented Nov 8, 2022

Closes #11750

Sadly, I tried to go the unification route where I wanted to use the upstream notifier as part of the messaging, but the images in notification made this impossible to work around.

That said, I do have a clear idea now of what we need to modify upstream to make this reality - for now, I'd like to ship this as is and use this exact notifier as the first guinea pig for the unification.

Screenshot 2022-11-08 at 20 08 06

TODO

  • Tests
  • Documentation
  • Alignment of settings with Prometheus Alertmanager

Closes #11750

Sadly, I tried to unification route where I wanted to use the upstream notifier as part of the messaging but the images in notification made this impossible to work around.

That said, I do have a clear idea now of what we need to modify upstream to make this reality - for now, I'd like to ship this as is and use this exact notifier as the first guinea ping for the unification.
Comment on lines 36 to 39
Message string `json:"message,omitempty" yaml:"message,omitempty"`
RoomID string `json:"room_id,omitempty" yaml:"room_id,omitempty"`
WebhookURL string `json:"webhook_url,omitempty" yaml:"webhook_url,omitempty"`
Token string `json:"bot_token" yaml:"bot_token"`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my most recent discovery - looking at the Webex documentation it seems that the recommended approach is to use a "Bot", the "Bot" comes with a Token that you can use to interact with the Webex rooms.

As such, the required configuration appears to be: A bot token and which room you want to send alerts too (1 at a time).

I couldn't figure out a way to include the token/room as part of the URL as I previously thought, which means that we probably don't need to encrypt the URL and just the token?

@grafanabot
Copy link
Contributor

Signed-off-by: gotjosh <josue.abreu@gmail.com>
@grafanabot
Copy link
Contributor

@grafanabot
Copy link
Contributor

Signed-off-by: gotjosh <josue.abreu@gmail.com>
@gotjosh gotjosh added this to the 9.3.0 milestone Nov 11, 2022
@gotjosh gotjosh marked this pull request as ready for review November 11, 2022 16:01
@gotjosh gotjosh requested review from mildwonkey, idafurjes and yangkb09 and removed request for a team November 11, 2022 16:01
@grafanabot
Copy link
Contributor

@grafanabot
Copy link
Contributor

@grafanabot
Copy link
Contributor

@gotjosh gotjosh enabled auto-merge (squash) November 11, 2022 17:26
@gotjosh gotjosh added the backport v9.2.x Mark PR for automatic backport to v9.2.x label Nov 11, 2022
@gotjosh gotjosh merged commit d748979 into main Nov 11, 2022
@gotjosh gotjosh deleted the webex-notifier branch November 11, 2022 17:27
grafanabot pushed a commit that referenced this pull request Nov 11, 2022
* Alerting: Implement the Webex notifier

Closes #11750

Signed-off-by: gotjosh <josue.abreu@gmail.com>
(cherry picked from commit d748979)
@leandro-deveikis leandro-deveikis modified the milestones: 9.3.0, 9.3.0-beta1 Nov 14, 2022
@gotjosh gotjosh added no-backport Skip backport of PR and removed backport v9.2.x Mark PR for automatic backport to v9.2.x labels Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add notifier for Webex Teams
5 participants