Chore: Migrate to use buf for protobuf generation #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marefr
requested review from
wbrowne,
andresmgot,
oshirohugo and
xnyo
and removed request for
a team
wbrowne
reviewed
May 7, 2024
wbrowne
approved these changes
May 7, 2024
xnyo
approved these changes
May 8, 2024
|
✅ https://github.com/grafana/test-datasource with this branch on grafana main works as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Migrate to use Buf CLI for generating protobuf files.
Bonus we can validate breaking changes in CI.
There's protobuf linter as well, but it does generate a lot of errors so skipping usage of that for now.
Which issue(s) this PR fixes:
Closes #751
Special notes for your reviewer: