Stop flooding cache logs on client disconnection/context cancelation #1347
+100
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariomac
requested review from
grcevski,
marctc and
rafaelroquetto
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1347 +/- ##
==========================================
- Coverage 81.06% 80.78% -0.29%
==========================================
Files 145 145
Lines 14558 14595 +37
==========================================
- Hits 11802 11791 -11
- Misses 2188 2226 +38
- Partials 568 578 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
marctc
reviewed
Nov 11, 2024
pkg/internal/kube/store.go
Outdated
| } | ||
| // the IPInfos could contain IPInfo data from Pods already sent in the previous loop | ||
| // is the subscriber the one that should decide whether to ignore such duplicates or | ||
| // incomplete info | ||
| for _, ips := range s.objectMetaByIP { | ||
| observer.On(&informer.Event{Type: informer.EventType_CREATED, Resource: ips}) | ||
| if err := observer.On(&informer.Event{Type: informer.EventType_CREATED, Resource: ips}); err != nil { | ||
| s.log.Debug("observer failed. Unsubscribing it", "observer", observer.ID(), "error", err) |
There was a problem hiding this comment.
is it worth to say in this line that is the observer for IPs? basically to differentiate from the previous logger
marctc
approved these changes
Nov 11, 2024
mattdurham
pushed a commit
to mattdurham/beyla
that referenced
this pull request
Jan 22, 2025
…rafana#1347) * Stop flooding cache logs on client disconnection/context cancelation * differentiate log messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1323
Also solves a potential leak where failed clients might be still running their goroutine.