Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting kubernetes version library #1341

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Nov 8, 2024

The later version of Kubernetes API library seem to introduce a memory leak and a goroutine leak. We can contribute to fix it but in the meanwhile we will revert the version.

This is the memory of a Beyla cache service Pod (the leak doesn't seem to happen in all the instances).

image

This is where the memory is spent for that service instance:

image

And the goroutines of that instance, compared to a healthy instance:

image

image

Copy link
Contributor

@marctc marctc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.28%. Comparing base (30424cf) to head (8e17c33).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1341      +/-   ##
==========================================
+ Coverage   78.76%   81.28%   +2.52%     
==========================================
  Files         144      144              
  Lines       14432    14432              
==========================================
+ Hits        11367    11731     +364     
+ Misses       2478     2135     -343     
+ Partials      587      566      -21     
Flag Coverage Δ
integration-test 59.54% <ø> (?)
k8s-integration-test 59.77% <ø> (-0.06%) ⬇️
oats-test 34.71% <ø> (ø)
unittests 52.02% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac merged commit 8aac1f9 into grafana:main Nov 8, 2024
13 checks passed
@mariomac mariomac deleted the revert-kube-api branch November 8, 2024 11:07
mattdurham pushed a commit to mattdurham/beyla that referenced this pull request Jan 22, 2025
* Reverting kubernetes version  library

* update third_party_licenses.csv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants