Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Docker Generator build action #1164

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Sep 12, 2024

The published generator image has become outdated and we can't update it because, by some reason, docker-build action does not support multiplatform by default (logs).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.05%. Comparing base (c6655f6) to head (6fb38c5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1164      +/-   ##
==========================================
+ Coverage   76.73%   81.05%   +4.31%     
==========================================
  Files         136      136              
  Lines       11416    11416              
==========================================
+ Hits         8760     9253     +493     
+ Misses       2125     1637     -488     
+ Partials      531      526       -5     
Flag Coverage Δ
integration-test 57.01% <ø> (-0.02%) ⬇️
k8s-integration-test 58.81% <ø> (?)
oats-test 35.77% <ø> (-0.08%) ⬇️
unittests 53.25% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit 72343e9 into grafana:main Sep 13, 2024
7 checks passed
@mariomac mariomac deleted the fix-generator branch September 13, 2024 07:56
mattdurham pushed a commit to mattdurham/beyla that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants