feat(otelcol/extension/jaeger_remote_sampling): resync defaults with upstreams #6763
Conversation
…upstreams Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
| @@ -27,9 +27,9 @@ func TestLoadConfig(t *testing.T) { | |||
| { | |||
| id: component.NewID(typeStr), | |||
| expected: &Config{ | |||
| HTTPServerConfig: &confighttp.ServerConfig{Endpoint: ":5778"}, | |||
| HTTPServerConfig: &confighttp.ServerConfig{Endpoint: "localhost:5778"}, | |||
There was a problem hiding this comment.
I think this might be surprising to users, as suddenly telemetry might be not be able to get pushed anymore.
Looking at the upstream docs I think the default is 0.0.0.0 for this reason. Can we align it with that value?
Once we start supporting OTel Collector feature gates (eg. such as component.UseLocalHostAsDefaultHost) then it might make sense to also support this.
There was a problem hiding this comment.
@tpaschalis If you look at this discussion upstream, they're working towards changing the default to 127.0.0.1 in a future release. Currently if you enable a specific feature gate (UseLocalHostAsDefaultHost) then all the components default to 127.0.0.1 instead.
I think we need to figure out if we're going to do this before 1.0, since it would be a breaking change when it does get implememnted.
There was a problem hiding this comment.
Since this is pretty breaking, maybe we can park this one and accept the deviance as part of grafana/agent features. Not sure how we can reconcile with upstream for this one.
rfratto
added
variant/flow
|
This PR has not had any activity in the past 30 days, so the |
github-actions
bot
added
the
needs-attention
PR Description
As of writing, the upstream has agreed upon limiting binding IP address to be
localhostinstead of0.0.0.0for security reasons. This PR is to reflect that upstream change.Which issue(s) this PR fixes
Fixes grafana/alloy#219
Notes to the Reviewer
PR Checklist