Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add support for inline TLS settings for Prometheus-based components #3524

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Apr 12, 2023

This updates the prometheus/common dependency to use a fork until prometheus/common#472 is merged.

Components which use the prometheus/common dependency for TLS configs will automatically support inline TLS settings. Some components, particularly loki.source.kafka and loki.source.syslog had to be updated as they build their own TLS configs.

Copy link
Contributor

@erikbaranowski erikbaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a lint and test to sort but overall LGTM

…ents

This updates the prometheus/common dependency to use a fork until
prometheus/common#472 is merged.

Components which use the prometheus/common dependency for TLS configs
will automatically support inline TLS settings. Some components,
particularly loki.source.kafka and loki.source.syslog had to be updated
as they build their own TLS configs.
@rfratto rfratto force-pushed the inline-tls-settings-prometheus-common branch from 9a526e3 to 626225f Compare April 12, 2023 18:37
@rfratto rfratto merged commit 83fa1e8 into grafana:main Apr 13, 2023
5 of 6 checks passed
@rfratto rfratto deleted the inline-tls-settings-prometheus-common branch April 13, 2023 18:33
clayton-cornell pushed a commit that referenced this pull request Aug 14, 2023
…ents (#3524)

This updates the prometheus/common dependency to use a fork until
prometheus/common#472 is merged.

Components which use the prometheus/common dependency for TLS configs
will automatically support inline TLS settings. Some components,
particularly loki.source.kafka and loki.source.syslog had to be updated
as they build their own TLS configs.
clayton-cornell pushed a commit that referenced this pull request Aug 14, 2023
…ents (#3524)

This updates the prometheus/common dependency to use a fork until
prometheus/common#472 is merged.

Components which use the prometheus/common dependency for TLS configs
will automatically support inline TLS settings. Some components,
particularly loki.source.kafka and loki.source.syslog had to be updated
as they build their own TLS configs.
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants