Merge pull request #6 from JLLeitschuh/feat/JLL/homoglyph_detector #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLLeitschuh
force-pushed
the
feat/JLL/homoglyph_detector
branch
from
77244d8
to
ae0da65
Compare
JLLeitschuh
commented
Jan 13, 2020
eskatos
requested changes
Jan 14, 2020
There was a problem hiding this comment.
It's nice to detect homoglyph attacks, but such attacks would already be very visible in git diffs so I don't see any urgency in adding such a feature to this action.
So, let's not inline the homoglyph library and instead use a dependency once your upstream PR is accepted.
There are also some conflicts to be resolved.
* master: Add : Build Rework output Let finding wrapper jars be predictable Ignore IDEA files
JLLeitschuh
force-pushed
the
feat/JLL/homoglyph_detector
branch
from
cd75714
to
9f4cacc
Compare
JLLeitschuh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added homoglyph detector was generated from this PR here (has updated unicode confusables):codebox/homoglyph#7This PR now uses the unhomoglyph project:
https://www.npmjs.com/package/unhomoglyph
This allows us to use a kind of fuzzy search to find all instances of the
gradle-wrapper.jarthat may also contain a homoglyph attack.