Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for version 3.x #968

Merged
merged 15 commits into from
Dec 23, 2023
Merged

Prepare for version 3.x #968

merged 15 commits into from
Dec 23, 2023

Conversation

bigdaz
Copy link
Member

@bigdaz bigdaz commented Nov 27, 2023

@bigdaz bigdaz self-assigned this Nov 27, 2023
Copy link

PR ready for review: https://gradle.com/s/uv3aipsr67thq

@bigdaz bigdaz force-pushed the prerelease/v3 branch 2 times, most recently from fae01e6 to 5fe1135 Compare December 13, 2023 20:41
@bigdaz bigdaz force-pushed the prerelease/v3 branch 3 times, most recently from 2a46a56 to 85de0aa Compare December 21, 2023 02:02
This makes it easier for users to enable config-cache saving in their workflow.

Config-cache data will only be saved/restored when the key is provided,
and the key is exported as `GRADLE_ENCRYPTION_KEY` for use in subsequent steps.
- Rename test for clarity
- Use cache-encryption-key in config-cache test
@bigdaz bigdaz force-pushed the prerelease/v3 branch 3 times, most recently from d012ec2 to 00214bf Compare December 23, 2023 06:08
- Avoid logging "not restoring" message when no entries exist to restore
- Clear the entries from metadata when they are not restored. This ensures that
  the non-restored entries are correctly purged.
- Filter out config-cache directories that do not exist when constructing
  cache entry definitions
Earlier versions of Gradle didn't support the `GRADLE_ENCRYPTION_KEY`
for the configuration-cache, and so are either not useful to save,
or are actually unsafe due to unencrypted secrets.

We use semver to compare the Gradle version used to produce the config-cache
entry with the minimum Gradle version required.
Config-cache save/restore is dependent on Gradle 8.6.
Use of the release-nightly is temporary until 8.6 is released.
- Avoid "Entry not saved: reason unknown" when entry was not restored
- Avoid "Entry not saved: Encryption key not provided" when no config-cache data found
- Avoid spurious log message when no config-cache data found
- Deprecate `build-root-directory` and `gradle-executable` parameters
- Remove examples from README
@bigdaz bigdaz changed the title Prerelease v3 Prepare for version 3.x Dec 23, 2023
@bigdaz bigdaz marked this pull request as ready for review December 23, 2023 19:42
@bigdaz bigdaz merged commit a7b7438 into main Dec 23, 2023
67 checks passed
@bigdaz bigdaz deleted the prerelease/v3 branch December 23, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant