Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the arguments parameter #996

Closed
bigdaz opened this issue Dec 12, 2023 · 3 comments · Fixed by #968
Closed

Deprecate the arguments parameter #996

bigdaz opened this issue Dec 12, 2023 · 3 comments · Fixed by #968
Milestone

Comments

@bigdaz
Copy link
Member

bigdaz commented Dec 12, 2023

The gradle-build-action is designed to be used in a "setup Gradle" step, configuring the local Gradle installation and Gradle User Home so that all subsequent Gradle invocations will benefit.

With the arguments parameter, the action will perform exactly the same setup, but will then invoke Gradle with the specified arguments. This adds very little value (over a subsequent run step), and can lead to issues with correctly parsing input arguments or processing build output.

By deprecating the arguments parameter, we will push users toward the recommended "setup Gradle" approach for using this action.

@bigdaz bigdaz added this to the 3.0.0 milestone Dec 12, 2023
bigdaz added a commit that referenced this issue Dec 13, 2023
@bigdaz bigdaz closed this as completed in f053e6b Dec 23, 2023
bigdaz added a commit that referenced this issue Dec 23, 2023
Contains all functionality planned for the initial 3.x release.

- Fixes #726 
- Fixes #946 
- Fixes #966 
- Fixes #996
bigdaz added a commit that referenced this issue Dec 23, 2023
@TWiStErRob
Copy link

@bigdaz Do you have plans to actually rename it to uses: gradle/setup-gradle@v3? to match all the other setup-ruby/setup-node/setup-java/setup-android/... actions and the intent of the action going forward? Note: the rename might be a non-breaking change because of GitHub's repository redirect feature (I haven't tested with actions yet, but 🤞).

@bigdaz
Copy link
Member Author

bigdaz commented Jan 2, 2024

@TWiStErRob Yes, something like that is the plan.

The action repo was earlier renamed from gradle/gradle-command-action to gradle/gradle-build-action and the repository redirect mostly worked, except I had some reports of issues from folks running GitHub Enterprise.

I'm not sure if the final name will be gradle/setup-gradle or if we want to consolidate a few different actions under a common repository, like:

  • gradle/actions/setup-gradle
  • gradle/actions/gradle-dependency-graph (pre-configured to generate-and-submit a dependency graph)
  • gradle/actions/wrapper-validation
  • etc.

If we do this, we have the benefit of a single repository for sharing code and development, but it will mean that all actions will be versioned together. I don't see this being much of an issue though. (The GitHub Actions release model is pretty brain-dead).

@TWiStErRob
Copy link

Nice, thanks for the detailed response. We decided for a mono-repo as well internally.

Note, there's an untested theory: we don't have to version everything together, we can create 3 tag prefixes, i.e. uses: gradle/actions/setup-gradle@setup-v4 or @v4.setup, whatever format makes Renovate/dependabot happy enough. This would mean one can use wrapper-validation@v4.setup, but hopefully people wouldn't, oh Murphy... :)

bwRavencl added a commit to bwRavencl/ControllerBuddy that referenced this issue Jan 29, 2024
Running gradle via gradle-build-action is no longer supported, instead it is recommended to use a run step - see: gradle/gradle-build-action#996
bwRavencl added a commit to bwRavencl/ControllerBuddy-Profiles that referenced this issue Jan 29, 2024
Running gradle via gradle-build-action is no longer supported, instead it is recommended to use a run step - see: gradle/gradle-build-action#996
msgilligan added a commit to msgilligan/bitcoinj that referenced this issue Jan 31, 2024
Upgrade to gradle/actions/setup-gradle@v3, which claims to be
backward-compatible with v2 (with the exception of requiring node 20)

The `arguments` parameter is now
deprecated (it is recommended to "setup" in one step and to
use the standard "run" action in a separate step), see:


See: gradle/gradle-build-action#996

However, for this PR we'll just upgrade to the latest version. We'll
deal with the deprecation in a separate PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants