Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add scorecard #384

Merged
merged 2 commits into from
Nov 13, 2024
Merged

ci: add scorecard #384

merged 2 commits into from
Nov 13, 2024

Conversation

nitrocode
Copy link
Contributor

what

  • add scorecard

why

  • Show scorecard to improve metrics
  • Scorecard will also show up on renovatebot PRs for this action

references

Verified

This commit was signed with the committer’s verified signature.
gaborbernat Bernát Gábor

Verified

This commit was signed with the committer’s verified signature.
gaborbernat Bernát Gábor
@bigdaz bigdaz merged commit 9e8f2bc into gradle:main Nov 13, 2024
3 checks passed
@nitrocode nitrocode deleted the scorecard branch November 14, 2024 05:22
@nitrocode
Copy link
Contributor Author

Thanks for merging!

@bigdaz
Copy link
Member

bigdaz commented Feb 19, 2025

@nitrocode I'm having trouble satisfying the code-review requirements for scorecard. Are you familiar with the algorithm used?

The issue is largely around bot-generated PRs and commits. Two examples:

  • This dependency-update PR was generated by a bot. I reviewed and merged the PR. But the "Code Review" score for the project went down as a result.
  • On each push to main, a workflow runs that runs npm and commits the output into the dist directory. Here's an example commit. Since this is an automated process, no review is performed and the bot commits the changes directly.

Is there a simple way I can change the process to satisfy the "code review" requirements, or am I stuck with a low score for this check?

@nitrocode
Copy link
Contributor Author

Hi @bigdaz

I looked at the docs and I see the following

Scoring is leveled instead of proportional to make the check more predictable. If any bot-originated changes are unreviewed, 3 points are deducted. If any human changes are unreviewed, 7 points are deducted if a single change is unreviewed, and another 3 are deducted if multiple changes are unreviewed.

Your PR and Bot Commit

See the conversation in this github issue ossf/scorecard#2450

Maybe bring this up as a separate issue (how to deal with keeping dist/ dir up to date without losing 7 points on code review metric)? Perhaps there is a different way to solve the problem than the bot commiting directly to the HEAD branch?

@bigdaz
Copy link
Member

bigdaz commented Feb 22, 2025

Thanks for checking. I'd prefer not to make the process less convenient in order to satisfy this (somewhat arbitrary) requirement.

For now I think I'll just ignore the CodeReview portion of the scorecard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add openssf scorecard
2 participants