Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds .expand() and .collapse() events to gr.Accordion #9875

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Conversation

abidlabs
Copy link
Member

@abidlabs abidlabs commented Oct 31, 2024

This PR was produced via programmatic use of aider + a lot of human intervention. More details available internally

Test with:

import gradio as gr

with gr.Blocks() as demo:
    with gr.Accordion("See Details") as accordion:
        gr.Markdown("lorem ipsum")

    t = gr.Textbox()

    accordion.expand(lambda: "Accordion is expanded", None, t)
    accordion.collapse(lambda: "Accordion is collapsed", None, t)

if __name__ == "__main__":
    demo.launch()

Closes: #5197

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 31, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/aeed53be37d1fe1caac03e4c5b3e05efbeaf28c7/gradio-5.4.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@aeed53be37d1fe1caac03e4c5b3e05efbeaf28c7#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/aeed53be37d1fe1caac03e4c5b3e05efbeaf28c7/gradio-client-1.7.1.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/aeed53be37d1fe1caac03e4c5b3e05efbeaf28c7/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 31, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/accordion minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Adds .expand() and .collapse() events to gr.Accordion

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@abidlabs
Copy link
Member Author

If there are any minor changes that need to be made, anyone should feel free to push to this branch. Thanks!

@freddyaboulton
Copy link
Collaborator

Should we expect that changing the open prop from python triggers the collapse or expand event? Otherwise LGTM!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@freddyaboulton
Copy link
Collaborator

Ok since the issue specifically calls out the Button, then it makes sense for expand/collapse to only trigger on user input.

@freddyaboulton freddyaboulton merged commit 8305ff8 into main Oct 31, 2024
22 of 23 checks passed
@freddyaboulton freddyaboulton deleted the aider2 branch October 31, 2024 18:55
@abidlabs
Copy link
Member Author

Thanks for merging this in @freddyaboulton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Can gradio Accordion have event click like Button
3 participants