-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copy all messages button to chatbot #9013
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/37141e9807203a720acfc0e4193936ec6f15cec6/gradio-4.41.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@37141e9807203a720acfc0e4193936ec6f15cec6#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/37141e9807203a720acfc0e4193936ec6f15cec6/gradio-client-1.5.0.tgz |
@@ -172,6 +172,7 @@ def __init__( | |||
likeable: bool = False, | |||
layout: Literal["panel", "bubble"] | None = None, | |||
placeholder: str | None = None, | |||
show_copy_all_button=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
show_copy_all_button=False, | |
show_copy_all_button: bool = False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @hannahblair! tested, works great
I agree about using the same copy icon. The position of the icon is enough to signify that it copies all messages
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
Description
Adds a copy all button (via a
show_copy_all_button
param) similar to gr.JSON and other components. I'm curious to know if we think this should look more unique to the other copy buttons in Chatbot 🤔Having other messages with copy buttons will look confusing, and scrolling will look terrible if users have copy buttons as well (which I've asked about in Slack)We could use a clipboard icon:
but then we're losing out on consistency between other components.
Also, should default be true or false?
Test:
Clipboard output:
Closes: #7446
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh