chatbot component tweaks #8594
Merged
chatbot component tweaks #8594
+721
−361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/4dcfdac49485babe06fb18613b33b09d27b8fa35/gradio-4.36.1-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@4dcfdac49485babe06fb18613b33b09d27b8fa35#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-builds.s3.amazonaws.com/4dcfdac49485babe06fb18613b33b09d27b8fa35/gradio-client-1.1.1.tgz |
pngwn
commented
Jun 21, 2024
pngwn
commented
Jun 21, 2024
pngwn
commented
Jun 21, 2024
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
pngwn
commented
Jun 21, 2024
pngwn
commented
Jun 21, 2024
pngwn
commented
Jun 21, 2024
pngwn
commented
Jun 21, 2024
pngwn
commented
Jun 21, 2024
pngwn
commented
Jun 23, 2024
pngwn
requested review from
aliabid94,
hannahblair,
abidlabs,
dawoodkhan82 and
freddyaboulton
hannahblair
reviewed
Jun 24, 2024
js/chatbot/shared/ChatBot.svelte
Outdated
| } | ||
| .bubble-gap { | ||
| gap: calc(var(--spacing-xxl) + var(--spacing-lg)); | ||
| } | ||
| .message-wrap | ||
| /* .message-wrap |
There was a problem hiding this comment.
do we need to remove this code?
hannahblair
reviewed
Jun 24, 2024
js/chatbot/shared/Copy.svelte
Outdated
Comment on lines
76
to
77
| width: 12px; | ||
| height: 12px; |
There was a problem hiding this comment.
I think these action buttons are too small 😬 see here. We should make it slightly larger and just make sure that the target inc. padding is 24x24. It's not too bad in desktop, but I definitely notice the small icon size in mobile.
hannahblair
reviewed
Jun 24, 2024
Noticed the loading bubble is looking stretched atm but we can fix in another PR |
* remove redundant like/dislike icons
…nto 8544-chatbot
|
Updated icon sizes from 12px -> 16px before/after 
|
hannahblair
reviewed
Jun 24, 2024
hannahblair
reviewed
Jun 24, 2024
hannahblair
reviewed
Jun 24, 2024
Comment on lines
41
to
45
| const _plot = Plotly.react( | ||
| plot_div, | ||
| plotObj.data, | ||
| plotObj.layout, | ||
| plotObj.config |
There was a problem hiding this comment.
No. This was from when I was trying to figure something out I think.
hannahblair
approved these changes
Jun 24, 2024
This was referenced Jun 24, 2024
Merged
Merged
|
Just catching up on some PRs. Thanks for adding all these fixes @pngwn ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a concise summary, in clear English, of the changes in this pull request. If it closes an issue, please mention it here.
Closes #8544
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh