-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes TabbedInterface bug where only first interface events get triggered #8504
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/70331159cf04e29904fb594ecdb0e3a2392db01f/gradio-4.36.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@70331159cf04e29904fb594ecdb0e3a2392db01f#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-builds.s3.amazonaws.com/70331159cf04e29904fb594ecdb0e3a2392db01f/gradio-client-1.1.0.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
@@ -1355,6 +1355,7 @@ def render(self): | |||
if isinstance(dep.api_name, str) | |||
] | |||
for dependency in self.fns.values(): | |||
dependency._id += dependency_offset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on using uuids for the ids @aliabid94 ?
) | ||
with connect(demo) as client: | ||
assert client.predict("Emily", api_name="/predict") == "Hello Emily" | ||
assert client.predict("Hannah", api_name="/predict") == "Hello Hannah" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should test the /predict_1
endpoint as well
assert client.predict("Hannah", api_name="/predict") == "Hello Hannah" | |
assert client.predict("Hannah", api_name="/predict_1") == "Bye Hannah" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks @freddyaboulton!
Description
Closes: #8425
Test with the following demo:
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh