remove static while pending behaviour #7410
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/ce2f3b4773d9580b83c36db115a75e777b72384b/gradio-4.18.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@ce2f3b4773d9580b83c36db115a75e777b72384b#subdirectory=client/python" |
|
I've tweaked a test here to get rid of some flake. The commented our part does not test anything (it will pass regardless) and causes the flake. |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
|
Actually i know how to fix that test. Will amend. |
There was a problem hiding this comment.
Is there a reason you removed the time.sleep? Without it, its not as clear that this is a streaming demo
There was a problem hiding this comment.
Clear in what way? It returns an iterator.
There was a problem hiding this comment.
Meaning visually when you run the demo, the text appears all at once, instead of the characters appearing one by one
There was a problem hiding this comment.
This demo is used in the docs here:
There was a problem hiding this comment.
Ah, we should really have dedicated demo's for tests. WIll fix.
There was a problem hiding this comment.
I'll create a new demo because i need to tweak the demo to fix the tests.
There was a problem hiding this comment.
Maybe we can use the _test suffix for designating test demos
There was a problem hiding this comment.
Maybe a prefix, so they are easier to find in the fs?
| @@ -525,22 +525,7 @@ | |||
| .on("status", ({ fn_index, ...status }) => { | |||
| tick().then(() => { | |||
| const outputs = dependencies[fn_index].outputs; | |||
| outputs.forEach((id) => { | |||
There was a problem hiding this comment.
We can also delete the line above (508) which defines const pending_outputs: number[] = [];
There was a problem hiding this comment.
We also have some additional logic involving outputs_set_to_non_interactive that can be deleted
|
Okay I cleaned this up and got the tests passing (i think, CI will tell). |
|
was wrong |
|
okay i think it should work now. |
Description
Please include a concise summary, in clear English, of the changes in this pull request. If it closes an issue, please mention it here.
Closes #7175
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh