-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preview_open and preview_close events to Gallery #10303
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/684668a055035bd074125fc3fae80d91cfcfd447/gradio-5.10.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@684668a055035bd074125fc3fae80d91cfcfd447#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/684668a055035bd074125fc3fae80d91cfcfd447/gradio-client-1.9.0.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/684668a055035bd074125fc3fae80d91cfcfd447/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @freddyaboulton! Your changes look good, but while testing this PR I noticed that the .change()
event of the interactive gr.Gallery
component does not fire when files are uploaded, so perhaps we can fix that as part of this PR.
Repro:
import gradio as gr
with gr.Blocks() as demo:
with gr.Row():
g1 = gr.Gallery()
g2 = gr.Gallery()
t = gr.Textbox(interactive=True)
g1.change(lambda x:x, g1, g2)
g2.preview_close(lambda : "hi", None, t)
demo.launch()
Thanks for the review @abidlabs ! Took care of that issue and modified the e2e tests to reflect the new behavior. |
* Add preview_open and preview_close events to Gallery * add changeset * notebooks * trigger change when upload --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Description
Closes: #6697
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.sh
Please run these bash scripts to automatically format your code:
bash scripts/format_backend.sh
, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh