Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed warning about not being able to find the app for some pattern #10290

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

YanSte
Copy link
Contributor

@YanSte YanSte commented Jan 5, 2025

Description

This pull request updates the regex pattern used to recognize Blocks declarations in the code.

Certain linting tools enforce a style of import.

The previous pattern only matched gr.Blocks, which caused issues when Blocks was used directly.
The updated pattern now supports both cases.

Closes: #10289
Closes: #6045

Following the previous patterns:

patterns = [
    f"with gr\\.Blocks\\(.*\\) as {demo_name}",
    f"{demo_name} = gr\\.Blocks",
    f"{demo_name} = gr\\.Interface",
    f"{demo_name} = gr\\.ChatInterface",
    f"{demo_name} = gr\\.TabbedInterface",
]

It's needed this format.

import gradio as gr
with gr.Blocks(...)

>> Watching: xxx

But certain linting tools enforce a style of import.

from gradio.blocks import Blocks
with Blocks(...)

>> Warning: Cannot statically find a gradio demo called demo. Reload work may fail.
>> Watching: xxx

Now, the updated pattern now supports both cases.

Verified

This commit was signed with the committer’s verified signature.
heifner Kevin Heifner
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jan 6, 2025

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/3b1c5365181e1911372806b87dd6f2867f8139c3/gradio-5.9.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@3b1c5365181e1911372806b87dd6f2867f8139c3#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/3b1c5365181e1911372806b87dd6f2867f8139c3/gradio-client-1.8.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/3b1c5365181e1911372806b87dd6f2867f8139c3/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jan 6, 2025

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fixed warning about not being able to find the app for some pattern

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Sorry, something went wrong.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @YanSte !

@freddyaboulton freddyaboulton enabled auto-merge (squash) January 6, 2025 20:53
@freddyaboulton freddyaboulton merged commit 99123e7 into gradio-app:main Jan 6, 2025
22 checks passed
@YanSte
Copy link
Contributor Author

YanSte commented Jan 8, 2025

@freddyaboulton Welcome 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants