Declare exports in __all__ for type checking #10238
Merged
+144
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @dustalov! I think this should be good, let me cc @aliabid94 @freddyaboulton for review |
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/cf2d0f68f8fc100f945d710c8dff949f75f4ce56/gradio-5.9.1-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@cf2d0f68f8fc100f945d710c8dff949f75f4ce56#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/cf2d0f68f8fc100f945d710c8dff949f75f4ce56/gradio-client-1.8.0.tgzUse Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/cf2d0f68f8fc100f945d710c8dff949f75f4ce56/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
freddyaboulton
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Thanks @dustalov ! Confirmed this fixes the issue on a fresh install
|
Thanks again @dustalov! I fixed some other typing issues and merged |
dawoodkhan82
pushed a commit
that referenced
this pull request
Dec 27, 2024
* Declare exports * add changeset * type fixes * more type fixes * add changeset * notebooks * changes --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Freddy Boulton <alfonsoboulton@gmail.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
abidlabs
added a commit
that referenced
this pull request
Jan 4, 2025
* save history prototype * add changeset * Declare exports in __all__ for type checking (#10238) * Declare exports * add changeset * type fixes * more type fixes * add changeset * notebooks * changes --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Freddy Boulton <alfonsoboulton@gmail.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * Add `gr.BrowserState` change event (#10245) * changes * changes * add changeset * format * changes --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> * history * changes * changes * changes * history * changes * changes * changes * format * add changeset * changes * changes * more changes * changes * dataset changes * changes * add changeset * add md variant for button * add changeset * changes * changes * format * format * add changeset * changes * changes * more changes * changes * changes * add changeset * changes * docs * changes * changes * changes * changes * fix * fix tests * change * add changeset * fix logo issue * changes * version * add changeset * fix typecheck * remove redundant * pkg version * add changeset * changes * Revert "changes" This reverts commit 13bfe8c. * reorganize code * format * changes * add to deployed demos * fix icons * fix icon * lint * changes * example * changes * fix buttons * add changeset * format * add changeset * update icon --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Dawood <dawoodkhan82@gmail.com> Co-authored-by: Dmitry Ustalov <dmitry.ustalov@gmail.com> Co-authored-by: Freddy Boulton <alfonsoboulton@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a project using Gradio enforces strict type checking, it results in errors due to missing symbols in Gradio's
__all__list: https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-implicit-reexport.This pull request fixes the issue by explicitly exporting the necessary symbols in
__init__.py.Closes: dustalov/evalica#25 (it impacted my personal project and the fix worked well for me)