Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reordering files in gr.File #10210

Merged
merged 5 commits into from
Dec 17, 2024
Merged

Allow reordering files in gr.File #10210

merged 5 commits into from
Dec 17, 2024

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented Dec 16, 2024

Description

Allows you to reorder the files in gr.File if the new allow_reordering param is True.

Closes: #10087

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Testing and Formatting Your Code

  1. PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests: bash scripts/run_backend_tests.sh

  2. Please run these bash scripts to automatically format your code: bash scripts/format_backend.sh, and (if you made any changes to non-Python files) bash scripts/format_frontend.sh

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Dec 16, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/d4953cf4f8cb357207d8d48b56003c7fbedb76c4/gradio-5.9.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@d4953cf4f8cb357207d8d48b56003c7fbedb76c4#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/d4953cf4f8cb357207d8d48b56003c7fbedb76c4/gradio-client-1.8.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/d4953cf4f8cb357207d8d48b56003c7fbedb76c4/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Dec 16, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/file minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Allow reordering files in gr.File

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Sorry, something went wrong.

@hannahblair hannahblair marked this pull request as ready for review December 16, 2024 18:08
Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @hannahblair, ui and implementation LGTM!

@abidlabs
Copy link
Member

I would maybe just wait off on merging this in until we have the patch release out

@abidlabs
Copy link
Member

Patch has been released, so we're good to merge this in now!

Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
@hannahblair hannahblair enabled auto-merge (squash) December 17, 2024 14:49
@hannahblair hannahblair merged commit 13a83e5 into main Dec 17, 2024
23 checks passed
@hannahblair hannahblair deleted the file-reorder branch December 17, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to reorder files in gr.File
3 participants