Allow editing chatbot messages #10203

aliabid94 · 2024-12-15T20:43:18Z

Adds the ability to edit chatbot messages. See below:

In a followup PR, I still need to:

Allow editing non-text messages (images, etc.)
Add editing to ChatInterface by default
When messages are grouped, allow editing other then the last message

Closes: #7919

gradio-pr-bot · 2024-12-15T21:12:13Z

🪼 branch checks and previews

•	Name	Status	URL
	Spaces	ready!	Spaces preview
	Website	ready!	Website preview
	Storybook	ready!	Storybook preview
🦄	Changes	detected!	Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/3c7a6885eabf1171b59c125703c2cf627938cf64/gradio-5.9.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@3c7a6885eabf1171b59c125703c2cf627938cf64#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/3c7a6885eabf1171b59c125703c2cf627938cf64/gradio-client-1.8.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/3c7a6885eabf1171b59c125703c2cf627938cf64/dist/lite.js""></script>

gradio-pr-bot · 2024-12-15T21:12:25Z

🦄 change detected

This Pull Request includes changes to the following packages.

Package	Version
`@gradio/chatbot`	`minor`
`gradio`	`minor`

Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Allow editing chatbot messages

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

Maintainers can change the version label to modify the version bump.
If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

freddyaboulton

Nice @aliabid94 - works well and the e2e is great. Just left some nits on the editing textbox size

gradio/components/chatbot.py

js/chatbot/shared/ChatBot.svelte

js/chatbot/shared/Message.svelte

abidlabs · 2024-12-16T17:49:27Z

Very nice UI @aliabid94! Left a comment on the parameter above. I'd also suggest we document this in https://www.gradio.app/guides/creating-a-custom-chatbot-with-blocks

aliabid94 · 2024-12-19T00:51:47Z

Ready for re-review and merge @abidlabs

gradio/components/chatbot.py

gradio/events.py

abidlabs · 2024-12-19T03:08:46Z

guides/05_chatbots/05_chatbot-specific-events.md

@@ -133,6 +133,22 @@ def handle_like(data: gr.LikeData):
 chatbot.like(vote, None, None)
 ```

+## The Edit Event
+
+Same idea with the edit listener! with `gr.Chatbot(editable=True)`, you can capture user edits as such:


I think editable chatbots deserves a bigger section than just this in the docs!

Suggested change

Same idea with the edit listener! with `gr.Chatbot(editable=True)`, you can capture user edits as such:

Same idea with the edit listener! with `gr.Chatbot(editable=True)`, you can capture user edits as such:

abidlabs

Looks great to me! Left a few minor comments

Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

* changes * add changeset * changes * changes * changes * changes * changes * changes * changes * Update gradio/events.py Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * Update gradio/components/chatbot.py Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * changes --------- Co-authored-by: Ali Abid <aliabid94@gmail.com> Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

* update code * modify imports * fix * update notebook * gr.load_chat: Allow loading any openai-compatible server immediately as a ChatInterface (#10222) * changes * add changeset * add changeset * Update gradio/external.py Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * changes * changes * Update guides/05_chatbots/01_creating-a-chatbot-fast.md Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * changes --------- Co-authored-by: Ali Abid <aliabid94@gmail.com> Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * Allow editing chatbot messages (#10203) * changes * add changeset * changes * changes * changes * changes * changes * changes * changes * Update gradio/events.py Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * Update gradio/components/chatbot.py Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * changes --------- Co-authored-by: Ali Abid <aliabid94@gmail.com> Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * Update Guides related to deploying Gradio chatbots to Discord, Slack, and website widgets (#10221) * changes * changes * update * chat history * add changeset * changes * add changeset * changes * guide * changes * changes * changes * guide * add images * slack guide * changes * format * add changeset * finish up slack * changes * improve js guide * update * changes * script * changes * changes * add changeset * Update guides/05_chatbots/01_creating-a-chatbot-fast.md Co-authored-by: Ali Abdalla <ali.si3luwa@gmail.com> * Update guides/05_chatbots/01_creating-a-chatbot-fast.md Co-authored-by: Ali Abdalla <ali.si3luwa@gmail.com> * Update guides/05_chatbots/06_creating-a-discord-bot-from-a-gradio-app.md Co-authored-by: Ali Abdalla <ali.si3luwa@gmail.com> * Update guides/05_chatbots/08_creating-a-website-widget-from-a-gradio-chatbot.md Co-authored-by: Ali Abdalla <ali.si3luwa@gmail.com> * Update guides/05_chatbots/08_creating-a-website-widget-from-a-gradio-chatbot.md Co-authored-by: Ali Abdalla <ali.si3luwa@gmail.com> * gradio * cta --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Ali Abdalla <ali.si3luwa@gmail.com> * Allow editable ChatInterface (#10229) * changes * add changeset * changes * changes * changes --------- Co-authored-by: Ali Abid <aliabid94@gmail.com> Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> * Fix typing for components in `gr.Interface` and docstring in `image.py` (#10235) * changes * add changeset * changes * changes * change * add changeset * image.py * revert msg --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> * Lite: Capture stdout and stderr from the main thread (#9984) * Add stdout and stderr events * add changeset * Refactoring * Format App.tsx * add changeset * Add python-error event to capture Python errors occurring in the running event loop after the initial app launch * Fix <ErrorDisplay />'s close button * Fix <ErrorDisplay /> * Propagate python-error and initialization-error events to the controller * Add init-code|file-run-error events --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> * use chat interface --------- Co-authored-by: Abubakar Abid <abubakar@huggingface.co> Co-authored-by: aliabid94 <aabid94@gmail.com> Co-authored-by: Ali Abid <aliabid94@gmail.com> Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Ali Abdalla <ali.si3luwa@gmail.com> Co-authored-by: Yuichiro Tachibana (Tsuchiya) <t.yic.yt@gmail.com>

changes

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

1d325f7

aliabid94 requested review from freddyaboulton, pngwn, hannahblair and abidlabs December 15, 2024 20:43

chages

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

Loading
Loading status checks…

9dc62f4

add changeset

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

Loading
Loading status checks…

d1144bb

Ali Abid added 2 commits December 15, 2024 13:15

changes

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

16e6298

changes

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

Loading
Loading status checks…

13a4adf

freddyaboulton reviewed Dec 16, 2024

View reviewed changes

gradio/components/chatbot.py Outdated Show resolved Hide resolved

js/chatbot/shared/ChatBot.svelte Outdated Show resolved Hide resolved

js/chatbot/shared/Message.svelte Show resolved Hide resolved

Ali Abid added 4 commits December 18, 2024 15:53

changes

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

Loading
Loading status checks…

b025001

changes

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

Loading
Loading status checks…

0297759

changes

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

Loading
Loading status checks…

b421b08

changes

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

Loading
Loading status checks…

04caec3

Ali Abid added 3 commits December 18, 2024 17:02

changes

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

Loading
Loading status checks…

0e3a7a3

changes

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

Loading
Loading status checks…

2fb7bb7

changes

Loading
Loading status checks…

4578d7a

abidlabs reviewed Dec 19, 2024

View reviewed changes

gradio/components/chatbot.py Outdated Show resolved Hide resolved

abidlabs reviewed Dec 19, 2024

View reviewed changes

gradio/events.py Outdated Show resolved Hide resolved

abidlabs reviewed Dec 19, 2024

View reviewed changes

abidlabs approved these changes Dec 19, 2024

View reviewed changes

aliabid94 and others added 3 commits December 19, 2024 15:30

Update gradio/events.py

Loading
Loading status checks…

80fdb16

Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

Update gradio/components/chatbot.py

Loading
Loading status checks…

0c818e8

Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

changes

Loading
Loading status checks…

48e7ac0

aliabid94 enabled auto-merge (squash) December 19, 2024 23:34

Merge branch 'main' into chatbot_editing

Loading
Loading status checks…

3c7a688

aliabid94 merged commit c3a9e64 into main Dec 19, 2024
22 of 23 checks passed

aliabid94 deleted the chatbot_editing branch December 19, 2024 23:54

gradio-pr-bot mentioned this pull request Dec 19, 2024

chore: update versions #10218

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow editing chatbot messages #10203

Allow editing chatbot messages #10203

aliabid94 commented Dec 15, 2024 •

edited by abidlabs

Loading

gradio-pr-bot commented Dec 15, 2024 •

edited

Loading

gradio-pr-bot commented Dec 15, 2024 •

edited

Loading

Something isn't right?

freddyaboulton left a comment

abidlabs commented Dec 16, 2024

aliabid94 commented Dec 19, 2024

abidlabs Dec 19, 2024

abidlabs left a comment

	Same idea with the edit listener! with `gr.Chatbot(editable=True)`, you can capture user edits as such:
	Same idea with the edit listener! with `gr.Chatbot(editable=True)`, you can capture user edits as such:

Allow editing chatbot messages #10203

Allow editing chatbot messages #10203

Conversation

aliabid94 commented Dec 15, 2024 • edited by abidlabs Loading

gradio-pr-bot commented Dec 15, 2024 • edited Loading

🪼 branch checks and previews

gradio-pr-bot commented Dec 15, 2024 • edited Loading

🦄 change detected

This Pull Request includes changes to the following packages.

With the following changelog entry.

Something isn't right?

freddyaboulton left a comment

Choose a reason for hiding this comment

abidlabs commented Dec 16, 2024

aliabid94 commented Dec 19, 2024

abidlabs Dec 19, 2024

Choose a reason for hiding this comment

abidlabs left a comment

Choose a reason for hiding this comment

aliabid94 commented Dec 15, 2024 •

edited by abidlabs

Loading

gradio-pr-bot commented Dec 15, 2024 •

edited

Loading

gradio-pr-bot commented Dec 15, 2024 •

edited

Loading