-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Microphone Input to MultimodalTextbox #10186
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/509488017882094dd3b3e3834ea4b5f35819db5f/gradio-5.9.1-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@509488017882094dd3b3e3834ea4b5f35819db5f#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/509488017882094dd3b3e3834ea4b5f35819db5f/gradio-client-1.8.0.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/509488017882094dd3b3e3834ea4b5f35819db5f/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
@abidlabs I see that for a split second as the page loads. But looks fine afterwards. |
Thanks @dawoodkhan82, loading now and works well. (Passed along some UI feedback in our 1-1) |
Tested this out @dawoodkhan82 and works well! Just a few suggestions, mostly around design and documentation. (1) The padding around the "Record" box looks off. The left border should be aligned with the left of the microphone icon underneath. The padding on the top should be increased to match the vertical gap between the box and the icons. ![]() (2) Bug: If I set (3) I created an example using import gradio as gr
def echo_sound(msg, history):
print("msg", msg)
return "x"
gr.ChatInterface(echo_sound, textbox=gr.MultimodalTextbox(sources=["microphone"]), multimodal=True).launch() Side note: you could make it such that clicking on the microphone button for a second time hides the record button. then you wouldn't need the "X" icon (4) It would be great to document this feature in both in the ChatInterface guide and in the custom Chatbot guide, as well as to add a storybook story for the Multimodal component. Otherwise lgtm! |
Description
Add microphone support to multimodal textbox. To test run demo:
chatbot_multimodal.py
Screen.Recording.2024-12-11.at.6.48.29.PM.mov
Closes: #9094
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.sh
Please run these bash scripts to automatically format your code:
bash scripts/format_backend.sh
, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh