Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix badges in readme, gofmt, and minor linting fix #284

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

thaJeztah
Copy link
Contributor

@thaJeztah thaJeztah commented Aug 29, 2024

README: update badge URLs

  • Update documentation badge URL to use pkg.go.dev
  • Update GoReportCard to point to the v3 version

README: remove mentions of non-go-modules

This information is a bit outdated by now, and it's unlikely for anyone to still be using go1.10 or older.

internal/difflib: gofmt

internal/difflib: rename funcs that collided with built-ins

min, max are a builtin since go1.21; https://go.dev/doc/go1.21#language

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
- Update documentation badge URL to use pkg.go.dev
- Update GoReportCard to point to the v3 version

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This information is a bit outdated by now, and it's unlikely
for anyone to still be using go1.10 or older.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
min, max are a builtin since go1.21; https://go.dev/doc/go1.21#language

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Member

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dnephin dnephin merged commit 8569bbc into gotestyourself:main Sep 5, 2024
6 checks passed
@thaJeztah thaJeztah deleted the cleanup_readme branch September 5, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants