fix TestFromDirSymlink on Windows due to missing drive-letter

[thaJeztah]

This test was failing, because it expected the drive-letter to always
be returned, which wasn't the case;

=== FAIL: fs TestFromDirSymlink (0.01s)
    ops_test.go:55: assertion failed: directory C:\Users\circleci\AppData\Local\Temp\test-from-dir-2260318643 does not match expected:
        \a\b\3
          target: expected C:\some\inexistent\link got \some\inexistent\link

This patch removes the special-case from d44953d,
which unconditionally added the drive-letter. Instead, we only change
the check to use the expected directory-separator.

[thaJeztah]

Hm... nope; that didn't help. Looks like something else needs to be updated; perhaps as part of the fs.Equal itself?

=== Failed
=== FAIL: fs TestFromDirSymlink (0.01s)
    ops_test.go:59: assertion failed: directory C:\Users\circleci\AppData\Local\Temp\test-from-dir-2043988436 does not match expected:
        \a\b\3
          target: expected C:\some\inexistent\link got \some\inexistent\link

Hm.. looking again, it looks like it's actual failing on the part related to

gotest.tools/fs/ops_test.go

Lines 39 to 41 in 631f6c8

	if runtime.GOOS == "windows" {
	link3 = filepath.Join(filepath.VolumeName(currentdir), link3)
	}

Looks like that was added in;

• Tell appveyor to enable symlinks #108
  • to address fs: Re-enable TestFromDirSymlink on windows #107

Maybe that part is no longer needed; let me try just removing it

[dnephin]

Thank you!

I guess the Go stdlib changed in a recent version? This test was passing for a long time.

[thaJeztah]

Yeah, no clue either; also honestly don't have a Windows machine to test locally 😂. Given that the original fix was a workaround for CI, and nobody complained that the code itself wasn't working, I'm pretty sure nothing was severely broken, so just the test.