Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove all versions < 1.16 and add 1.18 #793

Merged
merged 1 commit into from Jun 20, 2022
Merged

remove all versions < 1.16 and add 1.18 #793

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Expand Up @@ -16,8 +16,8 @@ jobs:
type: string
default: ""
docker:
- image: "circleci/golang:<< parameters.version >>"
working_directory: /go/src/github.com/gorilla/websocket
- image: "cimg/go:<< parameters.version >>"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://hub.docker.com/r/cimg/go

This image is designed to supercede the legacy CircleCI Go image, circleci/golang.

working_directory: /home/circleci/project/go/src/github.com/gorilla/websocket
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://circleci.com/docs/2.0/env-vars#using-parameters-and-bash-environment seems like hardcoding is necessary (i.e. can't use $HOME, it seems)

environment:
GO111MODULE: "on"
GOPROXY: "<< parameters.goproxy >>"
Expand Down Expand Up @@ -67,4 +67,4 @@ workflows:
- test:
matrix:
parameters:
version: ["latest", "1.17", "1.16", "1.15", "1.14", "1.13", "1.12", "1.11"]
version: ["1.18", "1.17", "1.16"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like they no longer publish with :latest tag:

$ docker pull cimg/go
Using default tag: latest
Error response from daemon: manifest for cimg/go:latest not found: manifest unknown: manifest unknown

likely due to ambiguity and confusion of using latest.