Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for and report bad protocol in TLSClientConfig.NextProtos #788

Merged
merged 10 commits into from
Jun 21, 2022
Merged

Check for and report bad protocol in TLSClientConfig.NextProtos #788

merged 10 commits into from
Jun 21, 2022

Commits on Jun 21, 2022

  1. return an error when Dialer.TLSClientConfig.NextProtos contains a pro… 

    …tocol that is not http/1.1
    Chan Kang committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    8a0b8d4 View commit details
    Browse the repository at this point in the history

  2. include the likely cause of the error in the error message

    Chan Kang committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    464f255 View commit details
    Browse the repository at this point in the history

  3. check for nil-ness of Dialer.TLSClientConfig before attempting to run… 

    … the check
    Chan Kang committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    a410921 View commit details
    Browse the repository at this point in the history

  4. addressing the review

    Chan Kang committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    1da1d61 View commit details
    Browse the repository at this point in the history

  5. move the NextProtos test into a separate file so that it can be run c… 

    …onditionally on go versions >= 1.14
    Chan Kang committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    b67992c View commit details
    Browse the repository at this point in the history

  6. moving the new error check into existing http response error block to… 

    … reduce the possibility of false positives
    Chan Kang committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    fc45505 View commit details
    Browse the repository at this point in the history

  7. wrapping the error in %w

    Chan Kang committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    d926999 View commit details
    Browse the repository at this point in the history

  8. using %v instead of %w for compatibility with older versions of go

    Chan Kang committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    d34dd94 View commit details
    Browse the repository at this point in the history

  9. Revert "using %v instead of %w for compatibility with older versions … 

    …of go"

This reverts commit d34dd94.
    Chan Kang committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    0cd10fc View commit details
    Browse the repository at this point in the history

  10. move the unit test back into the existing test code since golang buil… 

    …d constraint is no longer necessary
    Chan Kang committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    b7f4791 View commit details
    Browse the repository at this point in the history