Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: remove false-match for language detection #59

Merged
merged 1 commit into from Oct 10, 2018
Merged

github: remove false-match for language detection #59

merged 1 commit into from Oct 10, 2018

Conversation

nilslice
Copy link

@nilslice nilslice commented Oct 10, 2018

This fixes the language detection on Github, falsely inferring that over 50% of this codebase is in Scala. Not a major issue, but it caught me off guard at first!

image

@nilslice nilslice closed this Oct 10, 2018
@nilslice nilslice reopened this Oct 10, 2018
@nilslice
Copy link
Author

Sorry for the quick close-and-reopen on this. I didn't mean to create the PR at first, before checking that it worked on my fork.

@kisielk kisielk merged commit e65cf8c into gorilla:master Oct 10, 2018
@kisielk
Copy link
Contributor

kisielk commented Oct 10, 2018

Thanks

@elithrar
Copy link
Contributor

Thanks for this. I wasn't aware there was a way to coerce GitHub into ignoring specific directories!

@nilslice nilslice deleted the sm/gitattrs branch October 10, 2018 19:31
@nilslice
Copy link
Author

Happy to!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants