Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Add support for zone sharing in DNS v2 #3294

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Conversation

gophercloud-backport-bot[bot]
Copy link

Backport: #3286

This commit introduces functionality to share and unshare DNS zones with other projects using the OpenStack DNS v2 API. The following changes are included:

  • Added Share and Unshare methods in requests.go to handle API calls.
  • Updated results.go to include parsing for share/unshare responses.
  • Enhanced urls.go to generate proper URLs for share-related operations.
  • Created unit tests in requests_test.go to validate Share and Unshare.

These additions allow users to manage shared zones programmatically and align Gophercloud with the DNS v2 API capabilities.

Fixes #3048

Links to the line numbers/files in the OpenStack source code that support the code in this PR:

victorcam added 2 commits February 7, 2025 13:10
This commit introduces functionality to share and unshare DNS zones
with other projects using the OpenStack DNS v2 API. The following changes
are included:
- Added `Share` and `Unshare` methods in `requests.go` to handle API calls.
- Updated `results.go` to include parsing for share/unshare responses.
- Enhanced `urls.go` to generate proper URLs for share-related operations.
- Created unit tests in `requests_test.go` to validate `Share` and `Unshare`.

These additions allow users to manage shared zones programmatically
and align Gophercloud with the DNS v2 API capabilities.
@github-actions github-actions bot added edit:dns This PR updates dns code v2 This PR targets v2 semver:minor Backwards-compatible change labels Feb 7, 2025
@coveralls
Copy link

Coverage Status

coverage: 78.728% (-0.007%) from 78.735%
when pulling 979e4c8 on bp-v2-a0214a5-05687fb
into 297e9ec on v2.

@mandre mandre merged commit ec83492 into v2 Feb 7, 2025
23 checks passed
@mandre mandre deleted the bp-v2-a0214a5-05687fb branch February 7, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
edit:dns This PR updates dns code semver:minor Backwards-compatible change v2 This PR targets v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants