[v1] Context-aware methods to ProviderClient and ServiceClient #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierreprinetti
force-pushed
the
context-v1
branch
from
40fece3
to
0bb8600
Compare
github-actions
bot
added
semver:minor
pierreprinetti
force-pushed
the
context-v1
branch
from
0bb8600
to
889f21e
Compare
github-actions
bot
added
semver:minor
pierreprinetti
force-pushed
the
context-v1
branch
from
889f21e
to
e8bd3c5
Compare
github-actions
bot
added
semver:minor
pierreprinetti
force-pushed
the
context-v1
branch
from
e8bd3c5
to
843afd9
Compare
github-actions
bot
added
semver:minor
EmilienM
previously approved these changes
Feb 1, 2024
pierreprinetti
force-pushed
the
context-v1
branch
from
843afd9
to
6d76275
Compare
github-actions
bot
added
semver:minor
pierreprinetti
force-pushed
the
context-v1
branch
from
6d76275
to
2630165
Compare
github-actions
bot
added
semver:minor
|
One last change: Moved the context-merging function to an |
pierreprinetti
force-pushed
the
context-v1
branch
2 times, most recently
from
0984d6a
to
276dd63
Compare
github-actions
bot
added
semver:minor
pierreprinetti
force-pushed
the
context-v1
branch
from
276dd63
to
72f537b
Compare
github-actions
bot
added
semver:minor
EmilienM
previously approved these changes
Feb 1, 2024
mandre
reviewed
Feb 2, 2024
| ) | ||
|
|
||
| func TestMerge(t *testing.T) { | ||
| t.Run("returns values from both parents", func(t *testing.T) { |
There was a problem hiding this comment.
Let's just add a test for values that take precedence, as in #2883.
Provide new methods to leverage per-call `context.Context`. This patch, suitable to be merged to `v1`, vendors the context package from the v1.21 standard library, to make `AfterFunc` available.
pierreprinetti
force-pushed
the
context-v1
branch
from
72f537b
to
ef06ea2
Compare
github-actions
bot
added
semver:minor
EmilienM
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide new methods to leverage per-call
context.Context.Backports #2883
This patch, suitable to be merged to
v1, vendors the context package from the v1.21 standard library, to makeAfterFuncavailable.