Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1] Fix networking acceptance tests #2857

Merged
merged 2 commits into from
Jan 2, 2024
Merged

[v1] Fix networking acceptance tests #2857

merged 2 commits into from
Jan 2, 2024

Commits on Jan 2, 2024

  1. Fix networking acceptance tests 

    Since https://review.opendev.org/c/openstack/neutron/+/892815 it is no
longer possible to update the vnic type of a bound port.

These doesn't seem to be an API to unbind the port other than deleting
the port, so instead we're dropping the `VNICType` attribute from the
update request in the `TestPortsbindingCRUD` test.
    @mandre
    mandre committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    3c68a0f View commit details
    Browse the repository at this point in the history

  2. TestPortsbindingCRUD: Fix order of arguments in equal assertions 

    The correct order is `expected`, `actual`. Having this right helps
debugging since the values are printed in a log message.
    @mandre
    mandre committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    e707ba8 View commit details
    Browse the repository at this point in the history