Allow objects.CreateTempURL with names containing /v1/ #2826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierreprinetti
changed the title
pierreprinetti
force-pushed
the
tempurl_v1
branch
from
91beb09
to
72d7041
Compare
github-actions
bot
added
semver:patch
Before this patch, if an object's name or container name contained the string `/v1/`, it was not possible to create a TempURL for it. This was due to a bug in how the URL was split between the base part, and the object-path part. With this patch, container names or object names containing `/v1/` can have a TempURL created successfully.
pierreprinetti
force-pushed
the
tempurl_v1
branch
from
72d7041
to
3df6ee5
Compare
github-actions
bot
added
semver:patch
kayrus
approved these changes
Oct 26, 2023
EmilienM
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports a fix in CreateTempURL that was fixed in the main branch as a byproduct of #2821.
Before this patch, if an object's name or container name contained the string
/v1/, it was not possible to create a TempURL for it. This was due to a bug in how the URL was split between the base part, and the object-path part.With this patch, container names or object names containing
/v1/can have a TempURL created successfully.Fixes #2827