Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setSession to nil in recreateSession action to avoid unnecessary CloseSession #700

Merged
merged 1 commit into from
Dec 7, 2023
Merged

setSession to nil in recreateSession action to avoid unnecessary CloseSession #700

merged 1 commit into from
Dec 7, 2023

Commits on Dec 6, 2023

  1. setSession to nil when recreating to avoid unncessary call to CloseSe… 

    …ssion.

In the client.go monitor loop, the recreateSession action builds a new session on the assumption that the server is no longer holding the previous. It does not clear the value of atomicSession, which leads to CloseSession being called in ActivateSession even if there are no old sessions to be removed.

This behvior was referenced in issue gopcua#673.
    @mvandergrift
    mvandergrift committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    bc2e844 View commit details
    Browse the repository at this point in the history