Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(encode): print written hex on debugCodec flag #685

Merged
merged 3 commits into from
Aug 28, 2023
Merged

feat(encode): print written hex on debugCodec flag #685

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88d9fef
feat(encode): print written hex on debugCodec flag
sruehl Aug 25, 2023
ea0cba7
refactor(encode): rename logIntercept
sruehl Aug 25, 2023
3f854c3
feat(encode): improve hex dump output
sruehl Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 9 additions & 9 deletions ua/encode.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func encode(val reflect.Value, name string) ([]byte, error) {
switch {
case isBinaryEncoder(val):
v := val.Interface().(BinaryEncoder)
return logIntercept(v.Encode())
return dump(v.Encode())

case isTime(val):
buf.WriteTime(val.Convert(timeType).Interface().(time.Time))
Expand Down Expand Up @@ -79,25 +79,25 @@ func encode(val reflect.Value, name string) ([]byte, error) {
if val.IsNil() {
return nil, nil
}
return logIntercept(encode(val.Elem(), name))
return dump(encode(val.Elem(), name))
case reflect.Struct:
return logIntercept(writeStruct(val, name))
return dump(writeStruct(val, name))
case reflect.Slice:
return logIntercept(writeSlice(val, name))
return dump(writeSlice(val, name))
case reflect.Array:
return logIntercept(writeArray(val, name))
return dump(writeArray(val, name))
default:
return nil, errors.Errorf("unsupported type: %s", val.Type())
}
}
return logIntercept(buf.Bytes(), buf.Error())
return dump(buf.Bytes(), buf.Error())
}

func logIntercept(bytes []byte, err error) ([]byte, error) {
func dump(b []byte, err error) ([]byte, error) {
if debugCodec {
fmt.Printf("Wrote:\n%s\n", hex.Dump(bytes))
fmt.Printf("Wrote:\n%s\n", hex.Dump(b))
sruehl marked this conversation as resolved.
Show resolved Hide resolved
}
return bytes, err
return b, err
}

func writeStruct(val reflect.Value, name string) ([]byte, error) {
Expand Down