Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(encode): print written hex on debugCodec flag #685

Merged
merged 3 commits into from Aug 28, 2023
Merged

feat(encode): print written hex on debugCodec flag #685

merged 3 commits into from Aug 28, 2023

Conversation

sruehl
Copy link
Contributor

@sruehl sruehl commented Aug 25, 2023

resolves #684

magiconair
magiconair requested changes Aug 25, 2023
View reviewed changes
ua/encode.go Outdated Show resolved Hide resolved
ua/encode.go Outdated Show resolved Hide resolved
@magiconair magiconair added this to the v0.5.2 milestone Aug 25, 2023
magiconair
magiconair requested changes Aug 25, 2023
View reviewed changes
ua/encode.go Outdated Show resolved Hide resolved
@kung-foo kung-foo self-requested a review August 28, 2023 10:00
kung-foo
kung-foo approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@kung-foo kung-foo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Only issue is that I eventually want to move away from writing directly to stdout. We tend to use this in remote deployments where capturing stdout/err is a pita. But this is for a future revision.

@kung-foo kung-foo merged commit c48ab76 into gopcua:main Aug 28, 2023
5 checks passed
@sruehl sruehl deleted the feat/debug_encode_enhancements branch August 29, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magiconair magiconair magiconair approved these changes

@kung-foo kung-foo kung-foo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5.2
Development

Successfully merging this pull request may close these issues.

Feature: Enhanced encode log on debugCodec flag
3 participants
@sruehl @magiconair @kung-foo