fix(bigtable/bttest): Error when applying a mutation with an empty row key #9512
+52
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
|
As before, the Bigtable conformance tests are not failing because of this branch. For an example, see this recently merged pull request; the conformance tests fail for that. |
bhshkh
approved these changes
Apr 16, 2024
…w key Against a real version of Bigtable, an attempt to apply a mutation with an empty row key leads to the following error being produced ``` unable to apply: rpc error: code = InvalidArgument desc = Row keys must be non-empty ``` bttest does not conform to this behaviour. This commit: - adds error-handling when given a mutation with an empty row key, and - adds a regression test.
grpc.WithInsecure is deprecated. It was marked as such by v1.43.0 of the library. See here: grpc/grpc-go#4718 This commit removes a reference to this from the example comment.
adamroyjones
force-pushed
the
bttest-reject-empty-redux
branch
from
9191175
to
7b89cca
Compare
|
As it's been a few months, I've rebased onto the current version of main (54fab10). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This reopens #9450 (under a new branch name, given apparent limitations with GitHub). This was closed in #9510 with the message
which I don't think is true—it didn't affect what I mention below and so I don't know why #9450 was closed. #9510 has no obvious relationship with any of the changes, but I may be missing something.
Against a real version of Bigtable, an attempt to apply a mutation with an empty row key leads to the following error being produced
bttest does not conform to this behaviour. This branch:
It also, on a separate commit, removes a reference to a deprecated gRPC option from the example. (grpc.WithInsecure was marked as deprecated by v1.43.0 of the library. See here: grpc/grpc-go#4718.)