Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(bigtable): Adding isolation to app profile #8982

Merged
merged 2 commits into from Nov 9, 2023
Merged

test(bigtable): Adding isolation to app profile #8982

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c30555
test(bigtable): Adding isolation to app profile
bhshkh Nov 7, 2023
0a9a920
Merge branch 'main' into fix/issue-8742
bhshkh Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 17 additions & 5 deletions bigtable/integration_test.go
View file
Open in desktop
Expand Up @@ -2821,6 +2821,13 @@ func TestIntegration_InstanceAdminClient_AppProfile(t *testing.T) {
t.Fatalf("Get app profile: %v", err)
}

defer func() {
err = iAdminClient.DeleteAppProfile(ctx, adminClient.instance, profileID)
if err != nil {
t.Fatalf("Delete app profile: %v", err)
}
}()

if !proto.Equal(createdProfile, gotProfile) {
t.Fatalf("created profile: %s, got profile: %s", createdProfile.Name, gotProfile.Name)
}
Expand Down Expand Up @@ -2881,6 +2888,11 @@ func TestIntegration_InstanceAdminClient_AppProfile(t *testing.T) {
Description: "",
RoutingPolicy: gotProfile.RoutingPolicy,
Etag: gotProfile.Etag,
Isolation: &btapb.AppProfile_StandardIsolation_{
StandardIsolation: &btapb.AppProfile_StandardIsolation{
Priority: btapb.AppProfile_PRIORITY_HIGH,
},
},
},
},
{
Expand All @@ -2898,6 +2910,11 @@ func TestIntegration_InstanceAdminClient_AppProfile(t *testing.T) {
ClusterId: testEnv.Config().Cluster,
},
},
Isolation: &btapb.AppProfile_StandardIsolation_{
StandardIsolation: &btapb.AppProfile_StandardIsolation{
Priority: btapb.AppProfile_PRIORITY_HIGH,
},
},
},
},
} {
Expand All @@ -2923,11 +2940,6 @@ func TestIntegration_InstanceAdminClient_AppProfile(t *testing.T) {
})

}

err = iAdminClient.DeleteAppProfile(ctx, adminClient.instance, profileID)
if err != nil {
t.Fatalf("Delete app profile: %v", err)
}
}

func TestIntegration_InstanceUpdate(t *testing.T) {
Expand Down