Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): trace span covers life of a Reader #8390

Merged
merged 3 commits into from Aug 10, 2023
Merged

feat(storage): trace span covers life of a Reader #8390

merged 3 commits into from Aug 10, 2023

Commits on Aug 7, 2023

  1. feat(storage): trace span covers life of a Reader 

    Make the tracing span created in NewRangeReader cover the entire
lifecycle of the Reader. NewRangeReader returns before the
data transfer is complete, so it's more useful to track the
entire period until the Reader is closed.

NewRangeReader is still tracked with a span at the level of
individual transports (HTTP and gRPC).
    @tritone
    tritone committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    d931411 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. fix nil reader case

    @tritone
    tritone committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    f6a90ec View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Merge branch 'main' into reader-trace

    @tritone
    tritone committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    24277ad View commit details
    Browse the repository at this point in the history