Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): add support for matchGlob parameter #7728

Closed
wants to merge 5 commits into from
Closed

feat(storage): add support for matchGlob parameter #7728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e2709e5
feat(storage): add support for matchGlob parameter
goober Apr 11, 2023
476452d
Merge branch 'main' into feat/glob-match
goober Apr 11, 2023
c0cf690
Merge branch 'main' into feat/glob-match
goober Apr 11, 2023
356bbc4
Merge branch 'main' into feat/glob-match
goober May 22, 2023
27aa0de
Merge branch 'googleapis:main' into feat/glob-match
goober Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions storage/http_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,7 @@ func (c *httpStorageClient) ListObjects(ctx context.Context, bucket string, q *Q
req.EndOffset(it.query.EndOffset)
req.Versions(it.query.Versions)
req.IncludeTrailingDelimiter(it.query.IncludeTrailingDelimiter)
req.MatchGlob(it.query.MatchGlob)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also need to add this to the other interface implementation in grpc_client.go

if selection := it.query.toFieldSelection(); selection != "" {
req.Fields("nextPageToken", googleapi.Field(selection))
}
Expand Down
4 changes: 4 additions & 0 deletions storage/storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1527,6 +1527,10 @@ type Query struct {
// true, they will also be included as objects and their metadata will be
// populated in the returned ObjectAttrs.
IncludeTrailingDelimiter bool

// A glob pattern used to filter results (for example, foo*bar).
// The string value must be UTF-8 encoded.
MatchGlob string
}

// attrToFieldMap maps the field names of ObjectAttrs to the underlying field
Expand Down