Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prep for switching golint -> go vet #10223

Merged
merged 11 commits into from
May 20, 2024

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented May 17, 2024

Fix all the things.

Updates: #9784

@codyoss codyoss requested review from a team, shollyman and igorbernstein2 as code owners May 17, 2024 17:28
@codyoss codyoss added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 17, 2024
@codyoss codyoss added automerge Merge the pull request once unit tests and other checks pass. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 17, 2024
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 18, 2024
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label May 20, 2024
@codyoss codyoss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 20, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 20, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 21cba14 into googleapis:main May 20, 2024
16 of 18 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 20, 2024
@codyoss codyoss deleted the go-vet-the-things branch May 20, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants