-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bigtable): add column family type to FamilyInfo in TableInfo #10182
base: main
Are you sure you want to change the base?
Conversation
…ponse Change-Id: Iaa688f27c3472717929fbbdd03f3e12b8402c34a
Please add integration tests |
it := protoToType(agg.InputType) | ||
|
||
var aggregator Aggregator | ||
switch agg.Aggregator.(type) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nil checks missing on agg and agg.Aggregator
} | ||
|
||
func int64EncodingProtoToEncoding(ie *btapb.Type_Int64_Encoding) Int64Encoding { | ||
switch e := ie.Encoding.(type) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nil checks missing on ie and ie.encoding
} | ||
|
||
func (ua unknownAggregator) fillProto(proto *btapb.Type_Aggregate) { | ||
proto.Aggregator = ua.wrapped.Aggregator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pointer nil check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add nil checks wherever needed
This adds ValueType to FamilyInfo and populates it when calling TableInfo.
Internally it adds methods to convert from protobuf Type to our own type model.