Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bigtable): Adding isolation to app profile #8982

Merged
merged 2 commits into from Nov 9, 2023

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Nov 7, 2023

Isloation is a new field added to AppProfile proto. This is causing the tests to fail since there is a mismatch between app profile retrieved from Bigtable and the app profile the test is expecting.

  • Adding DeleteAppProfile call as cleanup that gets called irrespective of test failure / success
  • Adding Isolation to AppProfile

@bhshkh bhshkh requested review from a team as code owners November 7, 2023 00:29
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the Bigtable API. labels Nov 7, 2023
@bhshkh bhshkh requested a review from enocom November 7, 2023 18:04
@bhshkh bhshkh linked an issue Nov 7, 2023 that may be closed by this pull request
@bhshkh bhshkh merged commit a0b64f8 into googleapis:main Nov 9, 2023
9 of 12 checks passed
@bhshkh bhshkh deleted the fix/issue-8742 branch November 9, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bigtable: TestIntegration_InstanceAdminClient_AppProfile failed
3 participants