Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: determine if zero values are automatically set for OLM rules for gRPC #6205

Closed
frankyn opened this issue Jun 16, 2022 · 0 comments · Fixed by #8184
Closed

storage: determine if zero values are automatically set for OLM rules for gRPC #6205

frankyn opened this issue Jun 16, 2022 · 0 comments · Fixed by #8184
Assignees
@tritone
Labels
api: storage Issues related to the Cloud Storage API. type: process A process-related concern. May include testing, release, or the like.

Comments

@frankyn
Copy link
Member

frankyn commented Jun 16, 2022

Client

e.g. Storage

The implementation of OLM conversion from manual to gRPC might be accidentally sending zero values if at least one condition is set in an OLM rule.

Code block that should be investigated further: https://github.com/googleapis/google-cloud-go/blob/main/storage/bucket.go#L1560-L1571
@frankyn frankyn added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. labels Jun 16, 2022
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jun 17, 2022
@frankyn frankyn added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Jun 21, 2022
@frankyn frankyn added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 20, 2022
@codyoss codyoss added type: process A process-related concern. May include testing, release, or the like. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Nov 8, 2022
@noahdietz noahdietz mentioned this issue Dec 19, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Dec 20, 2022
@noahdietz
chore(storage): enable more grpc integration tests (#7179)
62d8329 
Enables a few tests for gRPC now that their fixes are in production.

One test is now only blocked on some behavior documented in #6205.
tritone added a commit to tritone/google-cloud-go that referenced this issue Jun 28, 2023
@tritone
fix(storage): fix AllObjects condition in gRPC
dfeaf94 
Fixes incorrect handling of zero values for the AgeDays field of
bucket lifecycle conditions. Allows re-enabling the integration test
for bucket create/delete for gRPC.

Fixes googleapis#6205
@tritone tritone mentioned this issue Jun 28, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 29, 2023
@tritone
fix(storage): fix AllObjects condition in gRPC (#8184)
2b99e4f 
Fixes incorrect handling of zero values for the AgeDays field of bucket lifecycle conditions. Allows re-enabling the integration test for bucket create/delete for gRPC.

Fixes #6205
@release-please release-please bot mentioned this issue Jun 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tritone tritone

Labels
api: storage Issues related to the Cloud Storage API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(storage): fix AllObjects condition in gRPC tritone/google-cloud-go
4 participants
@frankyn @tritone @codyoss @yoshi-automation