Skip to content

Commit

Permalink
chore(storage): enable more grpc integration tests (#7179)
Browse files Browse the repository at this point in the history
Enables a few tests for gRPC now that their fixes are in production.

One test is now only blocked on some behavior documented in #6205.
  • Loading branch information
noahdietz committed Dec 20, 2022
1 parent 74602fe commit 62d8329
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions storage/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ func multiTransportTest(ctx context.Context, t *testing.T,
}

func TestIntegration_BucketCreateDelete(t *testing.T) {
multiTransportTest(skipGRPC("with_attrs case fails due to b/245997450"), t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) {
multiTransportTest(skipGRPC("with attrs: https://github.com/googleapis/google-cloud-go/issues/6205"), t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) {
projectID := testutil.ProjID()

labels := map[string]string{
Expand Down Expand Up @@ -471,7 +471,7 @@ func TestIntegration_BucketCreateDelete(t *testing.T) {
}

func TestIntegration_BucketLifecycle(t *testing.T) {
multiTransportTest(skipGRPC("b/245997450"), t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) {
multiTransportTest(context.Background(), t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) {
h := testHelper{t}

wantLifecycle := Lifecycle{
Expand Down Expand Up @@ -928,7 +928,7 @@ func TestIntegration_ConditionalDelete(t *testing.T) {
}

func TestIntegration_ObjectsRangeReader(t *testing.T) {
multiTransportTest(skipGRPC("b/250958907"), t, func(t *testing.T, ctx context.Context, bucket string, _ string, client *Client) {
multiTransportTest(context.Background(), t, func(t *testing.T, ctx context.Context, bucket string, _ string, client *Client) {
bkt := client.Bucket(bucket)

objName := uidSpace.New()
Expand Down

0 comments on commit 62d8329

Please sign in to comment.