Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Conditionally import requests only if no request was passed by the caller. #1456

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

clundin25
Copy link
Contributor

@clundin25 clundin25 commented Jan 18, 2024

This resolves #1455.

The repo-wide pattern is to only import the requests module at runtime as a fallback.

@clundin25 clundin25 requested review from a team as code owners January 18, 2024 22:03
@clundin25 clundin25 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2024
@clundin25 clundin25 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 19, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 9cd6742 into googleapis:main Jan 19, 2024
14 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 19, 2024
cpisunyer pushed a commit to cpisunyer/google-auth-library-python that referenced this pull request Jan 22, 2024
…he caller. (googleapis#1456)

This resolves https://togithub.com/googleapis/google-auth-library-python/issues/1455.

The repo-wide pattern is to only import the requests module at runtime as a fallback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError in google.oauth2.id_token
2 participants