Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updates UserAuthorizer to support retrieving token response directly with different client auth types #1486

Merged
merged 8 commits into from
Sep 5, 2024
Merged

feat: updates UserAuthorizer to support retrieving token response directly with different client auth types #1486

merged 8 commits into from
Sep 5, 2024
+995 −254

Conversation

lsirac
Copy link
Contributor

@lsirac lsirac commented Aug 28, 2024 •
edited
Loading

Adds support for the following in UserAuthorizer:

  • Different client auth types
  • A method to retrieve the token response directly, not UserCredentials, allowing for it to be used in more ways (e.g. enables Workforce Identity Federation)
  • Constructor now takes in the Builder directly

@lsirac lsirac requested a review from a team as a code owner August 28, 2024 19:39
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Aug 28, 2024
lsirac and others added 2 commits August 28, 2024 15:49
@lsirac
fix: cleanup
Loading
Loading status checks…
7f305e6
@lsirac
Merge branch 'main' into userauthorizer
Loading
Loading status checks…
67e81aa
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@lsirac lsirac requested a review from aeitzman August 28, 2024 19:57
@lsirac
fix: review

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
3f0a97a
@lsirac lsirac requested a review from a team as a code owner September 3, 2024 22:12
@lsirac lsirac requested a review from lqiu96 September 3, 2024 22:17
@lqiu96 lqiu96 requested a review from zhumin8 September 4, 2024 14:29
lsirac and others added 2 commits September 5, 2024 03:15
@lsirac
Merge branch 'main' into userauthorizer
Loading
Loading status checks…
2c7ef85
@lsirac
fix: review suggestions
Loading
Loading status checks…
2dfadaa
@lsirac lsirac requested a review from lqiu96 September 5, 2024 10:28
@lsirac
fix: incorrect import
Loading
Loading status checks…
11c1389
@lsirac
fix: adds missing check
Loading
Loading status checks…
adaf2b8
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 5, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@lqiu96
Copy link
Contributor

lqiu96 commented Sep 5, 2024

Thanks @lsirac, LGTM. Added some last comment if you could take a look as well.

@lsirac lsirac merged commit 1651006 into googleapis:main Sep 5, 2024
18 checks passed
@release-please release-please bot mentioned this pull request Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sai-sunder-s sai-sunder-s

@lqiu96 lqiu96

@aeitzman aeitzman

@zhumin8 zhumin8

Assignees
No one assigned
Labels
size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lsirac @lqiu96 @sai-sunder-s @aeitzman