New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Universe Domain Support #2435
Merged
+526
−6
Merged
Changes from 23 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
b49eeca
feat: Implement Universe Domain Support
lqiu96 e15caa2
chore: Clean up auth dependencies
lqiu96 4544811
chore: Resolve checkstyle issues
lqiu96 3b8a90a
chore: Determine service name from url
lqiu96 544ee32
chore: Return null for invalid rootUrl
lqiu96 2ba2504
chore: Add javadocs for Universe Domain changes in AbstractGoogleClient
lqiu96 25c9bc8
chore: Address checkstyle issues
lqiu96 13418de
chore: Add tests for AbstractGoogleClient
lqiu96 b8b233a
chore: Fix tests
lqiu96 dfd07a7
chore: Update docs for AbstractGoogleClient
lqiu96 a9a64db
chore: validateUniverseDomain does not return bool
lqiu96 0f905c0
chore: Move validateUniverseDomain() to parent impl
lqiu96 b2088be
chore: Update javadocs
lqiu96 fd1182a
chore: Add Env Var tests for GOOGLE_CLOUD_UNIVERSE_DOMAIN
lqiu96 3edfe45
chore: Fix lint issues
lqiu96 bba201a
chore: Fix env var tests
lqiu96 7a0b3fa
chore: Update logic for isUserConfiguredEndpoint
lqiu96 83612b6
chore: Throw IOException on validateUniverseDomain
lqiu96 1cfd93a
chore: Address PR comments
lqiu96 3fcb3c8
chore: Address PR comments
lqiu96 8d11d10
chore: Address PR comments
lqiu96 46781b1
chore: Address PR comments
lqiu96 9c8084c
chore: Validate on HttpCredentialsAdapter
lqiu96 94c42d1
chore: Address PR comments
lqiu96 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Change this to
for better readability.