feat: Add extension method for IHttpExecuteInterceptor to create a DelegatingHandler #2453
+145
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskeet
added
the
do not merge
|
Great. Will wait for feedback from @EricStG, then write a quick integration test (e.g. listing Storage buckets), fill in docs etc - next week. |
…legatingHandler Fixes googleapis#2450
jskeet
force-pushed
the
delegating-auth-handler
branch
from
58f3501 to
ae5362d
Compare
jskeet
changed the title
jskeet
removed
the
do not merge
|
Given the simplicity of the code, I've only added an integration test. Let me know if you'd like unit tests as well. |
|
(I can split the PR into two, one adding the interface to GoogleCredential and one adding the extension method, if that would be useful.) Once this is released, I'll add documentation to https://cloud.google.com/dotnet/docs/reference/help/rest-libraries |
amanda-tarafa
added a commit
that referenced
this pull request
Sep 5, 2023
amanda-tarafa
added a commit
that referenced
this pull request
Sep 5, 2023
amanda-tarafa
added a commit
that referenced
this pull request
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed plan for #2450
Lacking documentation and tests right now...
(Basically, this is all simple if folks have a concrete credential, as they all either implement IHttpExecuteInterceptor, or can do so very simply, such as GoogleCredential.)