feat(gengapic): add universe domain support #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
quartzmo
commented
Jan 19, 2024
quartzmo
commented
- upgrade showcase google.golang.org/api to v0.157.0
|
Similar to googleapis/google-api-go-client#2335 |
noahdietz
reviewed
Jan 22, 2024
Comment on lines
+180
to
+182
| p(" internaloption.WithDefaultEndpointTemplate(%q),", generateDefaultEndpointTemplate(host)) | ||
| p(" internaloption.WithDefaultMTLSEndpoint(%q),", generateDefaultMTLSEndpoint(host)) | ||
| p(" internaloption.WithDefaultUniverseDomain(%q),", googleDefaultUniverse) |
There was a problem hiding this comment.
Without knowing much how this will ultimately work, do the WithDefaultEndpoint and WithDefaultMTLSEndpoint options go away assuming endpoint resolution is done by the middleware?
There was a problem hiding this comment.
WithDefaultEndpoint is already deprecated, and will eventually go away post-transition. WithDefaultMTLSEndpoint is unaffected by these changes as that auth flow does not support universe domain.
noahdietz
approved these changes
Jan 23, 2024
|
Thanks, yes the For example: https://github.com/googleapis/google-cloud-go/blob/main/accessapproval/go.mod#L7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.