Skip to content

Commit

Permalink
Include =disabled in various AIP 203 instructions (#1) (#494)
Browse files Browse the repository at this point in the history
* Add =disabled to 0203/immutable.md instructions

* Add =disabled to 0203/input-only.md instructions

* Add =disabled to 0203/optional-conflict.md

* Add =disabled to 0203/optional-consistency.md instructions

* Add =disabled to 0203/optional.md instructions

* Add =disabled to 0203/output-only.md instructions
  • Loading branch information
0x4b committed Feb 13, 2020
1 parent 7b6a2d2 commit 64516bd
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion docs/rules/0203/immutable.md
Expand Up @@ -66,7 +66,7 @@ message Book {
string name = 1;
// Immutable. The title of the book.
// (-- api-linter: core::0203::immutable
// (-- api-linter: core::0203::immutable=disabled
// aip.dev/not-precedent: We need to do this because reasons. --)
string title = 2;
}
Expand Down
2 changes: 1 addition & 1 deletion docs/rules/0203/input-only.md
Expand Up @@ -66,7 +66,7 @@ message Book {
string name = 1;
// Input only. The password used to check out this book.
// (-- api-linter: core::0203::input-only
// (-- api-linter: core::0203::input-only=disabled
// aip.dev/not-precedent: We need to do this because reasons. --)
string access_password = 2;
}
Expand Down
2 changes: 1 addition & 1 deletion docs/rules/0203/optional-conflict.md
Expand Up @@ -56,7 +56,7 @@ message Book {
string name = 1;
// Optional. The foreword for the book.
// (-- api-linter: core::0203::optional-conflict
// (-- api-linter: core::0203::optional-conflict=disabled
// aip.dev/not-precedent: We need to do this because reasons. --)
string foreword = 2 [
(google.api.field_behavior) = OPTIONAL,
Expand Down
2 changes: 1 addition & 1 deletion docs/rules/0203/optional-consistency.md
Expand Up @@ -74,7 +74,7 @@ If you need to violate this rule, use a leading comment above the message.
Remember to also include an [aip.dev/not-precedent][] comment explaining why.

```proto
// (-- api-linter: core::0203::optional-consistency
// (-- api-linter: core::0203::optional-consistency=disabled
// aip.dev/not-precedent: We need to do this because reasons. --)
message Book {
string name = 1;
Expand Down
2 changes: 1 addition & 1 deletion docs/rules/0203/optional.md
Expand Up @@ -67,7 +67,7 @@ message Book {
string name = 1;
// Optional. The foreword for the book.
// (-- api-linter: core::0203::optional
// (-- api-linter: core::0203::optional=disabled
// aip.dev/not-precedent: We need to do this because reasons. --)
string foreword = 2;
}
Expand Down
2 changes: 1 addition & 1 deletion docs/rules/0203/output-only.md
Expand Up @@ -68,7 +68,7 @@ message Book {
string name = 1;
// Immutable. The title of the book.
// (-- api-linter: core::0203::output-only
// (-- api-linter: core::0203::output-only=disabled
// aip.dev/not-precedent: We need to do this because reasons. --)
// Output only. When the book was published.
google.protobuf.Timestamp publish_time = 2;
Expand Down

0 comments on commit 64516bd

Please sign in to comment.