Consolodate and improve use of old names #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit builds on #980 in a few ways: - Consolodates `use` lines so we can avoid repeating the same comment multiple times. - Applies the same technique to the old `LayoutVerified` name (for what is now called `Ref`) - In #980, we spuriously left `IntoBytes as AsBytes` as a `pub use` rather than just a `use`, which caused us to need to keep the `--cfg __INTERNAL_USE_ONLY_DISABLE_DEPRECATED_TRAIT_ALIASES` in order to keep CI passing. We fix that in this commit, and thus can remove that `--cfg`.
jswrenn
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit builds on #980 in a few ways:
uselines so we can avoid repeating the same comment multiple times.LayoutVerifiedname (for what is now calledRef)IntoBytes as AsBytesas apub userather than just ause, which caused us to need to keep the--cfg __INTERNAL_USE_ONLY_DISABLE_DEPRECATED_TRAIT_ALIASESin order to keep CI passing. We fix that in this commit, and thus can remove that--cfg.